[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

2023-02-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D143640#4122603 , @hokein wrote: > Thanks for the comment, putting more thoughts. > > In D143640#4121998 , @kadircet > wrote: > >> All this complexity for handling only 4 symbols feel

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

2023-02-13 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for the comment, putting more thoughts. In D143640#4121998 , @kadircet wrote: > All this complexity for handling only 4 symbols feels wrong. is this the > whole set? are there any other symbols that fall under this class?

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

2023-02-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. All this complexity for handling only 4 symbols feels wrong. is this the whole set? are there any other symbols that fall under this class? can we disambiguate all of them solely based on number of parameters? Downsides: - We are relying heavily on number of parameters

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

2023-02-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143640 Fil