thieta added a comment.
Thanks for the review and the explanations! I fixed your nits and landed this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143632/new/
https://reviews.llvm.org/D143632
___
cfe-c
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG877859a09bda: [clang] Handle __declspec() attributes in
using (authored by thieta).
Changed prior to commit:
https://reviews.llvm.org/D143632?vs=4
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits that you can fix when landing, thank you for
the fix!
Comment at: clang/docs/ReleaseNotes.rst:112-114
+__declspec attributes ca
thieta marked an inline comment as done.
thieta added a comment.
Thanks for your comments - feel free to comment on the release note, I was
struggling with describing the fix well for a short release note paragraph.
Comment at: clang/lib/Parse/ParseDecl.cpp:61-63
+ for (Parse
thieta updated this revision to Diff 496906.
thieta marked 2 inline comments as done.
thieta added a comment.
- Expand on tests
- Fix crash when Attrs was null
- Added release note
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143632/new/
https://r
aaron.ballman added a reviewer: erichkeane.
aaron.ballman added a comment.
Please be sure to add a release note for the fix.
Comment at: clang/lib/Parse/ParseDecl.cpp:61-63
+ for (ParsedAttr &AL : DS.getAttributes())
+if (AL.isDeclspecAttribute())
+ ToBeMoved.push_bac
thieta created this revision.
thieta added reviewers: aaron.ballman, rsmith, tbaeder, saudi.
Herald added a project: All.
thieta requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch fixes so that declspec attributes are forwarded
to t
