[PATCH] D143560: clang-format.el: fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG95c3c2b8570d: [clang-format] clang-format.el: fix warnings (authored by augfab, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/n

[PATCH] D143560: clang-format.el: fix warnings

augfab marked 5 inline comments as done. augfab added a comment. All comments were addressed, marking them as Done. I don't have commit access, here's my name and email: Augustin Fabre . Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D14356

[PATCH] D143560: clang-format.el: fix warnings

HazardyKnusperkeks added a comment. In D143560#4149733 , @phst wrote: > I'm not super familiar with the process either, but IIRC @sammccall or > @djasper have to merge this. Anyone with commit access can do that. In D143560#4147918

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added a comment. please mark the comments as done when you've addressed them CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added subscribers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. MyDeveloperDay added a comment. I'm one of the code owners for clang-format, but I'm not an emacs user (don't hate me..), honestly I don't think you'll get a response from anyone others than the clang-format

[PATCH] D143560: clang-format.el: fix warnings

phst added a comment. I'm not super familiar with the process either, but IIRC @sammccall or @djasper have to merge this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list

[PATCH] D143560: clang-format.el: fix warnings

augfab added a comment. Hi @phst , is anything left for me to do before this patch is merged? This is my first patch to LLVM so I'm not too familiar with the process. Thanks for your help 🙂 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 _

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby accepted this revision. DavidTruby added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D143560: clang-format.el: fix warnings

augfab updated this revision to Diff 495815. augfab edited the summary of this revision. augfab added a comment. Applied suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 Files: clang/tools/clang-format/clang-format.el Index: cl

[PATCH] D143560: clang-format.el: fix warnings

augfab added inline comments. Comment at: clang/tools/clang-format/clang-format.el:70 (cl-case (xml-node-name node) -('replacement +((replacement quote) (let* ((offset (xml-get-attribute-or-nil node 'offset)) phst

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby added a comment. I think the other suggestion from the warning should be applied, as I don't think it _is_ intended that "quote" is matched by either of these. It would actually be odd if it did as you'd have two matches. Comment at: clang/tools/clang-format/clang-

[PATCH] D143560: clang-format.el: fix warnings

phst requested changes to this revision. phst added inline comments. This revision now requires changes to proceed. Comment at: clang/tools/clang-format/clang-format.el:70 (cl-case (xml-node-name node) -('replacement +((replacement quote)

[PATCH] D143560: clang-format.el: fix warnings

augfab created this revision. augfab added reviewers: sammccall, phst, djasper. augfab added a project: clang-format. Herald added a project: All. augfab requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Emacs trunk complained about: Warni