Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL252170.
https://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.ll
klimek marked 2 inline comments as done.
klimek added a comment.
Addressed comments.
http://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek updated this revision to Diff 39287.
klimek added a comment.
Remove unnecessary if and fix segfault.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: tes
rsmith added inline comments.
Comment at: lib/Lex/ModuleMap.cpp:235-237
@@ -234,5 +234,1 @@
return IsPrivateRole &&
- // FIXME: Should we map RequestingModule to its top-level module here
- //too? This check is redundant with the isSubModuleOf check in
-
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: test/Modul
