This revision was automatically updated to reflect the committed changes.
Closed by commit rL252827: Add diagnostics which fall under
[dcl.spec.concept]p5 (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D14352?vs=39386&id=39986#toc
Repository:
rL LLVM
http://reviews.
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
nwilson updated this revision to Diff 39386.
nwilson added a comment.
- replace hyphen and apostrophe with equivalent ASCII characters
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.conc
nwilson updated this revision to Diff 39314.
nwilson added a comment.
- Cover variadic arguments in check for no params.
- Add tests to cover variadic arguments.
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/concepts-ts/dcl
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:7
@@ +6,2 @@
+template
+concept bool fcpi(int i = 0) { return true; } // expected-error {{function
concept cannot have any parameters}}
hubert.
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7575
@@ +7574,3 @@
+// following restrictions:
+// — The declaration’s parameter list shall be equivalent to an empty
+// parameter list.
I think the U+2014 s
nwilson created this revision.
nwilson added reviewers: rsmith, faisalv, hubert.reinterpretcast, aaron.ballman.
nwilson added a subscriber: cfe-commits.
Diagnose when a function concept declaration has parameter(s)
http://reviews.llvm.org/D14352
Files:
include/clang/Basic/DiagnosticSemaKinds.t
