This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG41a6085252ef: [clangd] Fix a crash in semantic highlighting.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein updated this revision to Diff 495496.
hokein marked an inline comment as done.
hokein added a comment.
add a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143486/new/
https://reviews.llvm.org/D143486
Files:
clang-tools-extra/clan
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:524
const auto *Tok = TB.spelledTokenAt(Loc);
-assert(Tok);
-
+if (!Tok)
+ return std:
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
We encounter a few internal repo