This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG968b4172f6a9: [clang][Interp] Fix derived-to-base casts for
>1 levels (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D14
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143480/new/
https://reviews.llvm.org/D143480
___
cfe-commits mailing lis
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:266
};
#endif
aaron.ballman wrote:
> I think it'd be good to add test coverage for cases like:
> https://godbolt.org/z/GnPnP4z76
That even worked :)
CHANGES SINCE LAST ACTION
ht
tbaeder updated this revision to Diff 504022.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143480/new/
https://reviews.llvm.org/D143480
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/I
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1949
+ // Pointer of derived type is already on the stack.
+ const CXXRecordDecl *FinalDecl = cast(BaseType->getDecl());
+ const RecordDecl *CurDecl = DerivedType->getDecl();
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143480/new/
https://reviews.llvm.org/D143480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The GetPtrBasePop op we were using only works for
