[PATCH] D143466: [clang][Interp] Fix initializing base class members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb3dcdc08ce0: [clang][Interp] Fix initializing base class members (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 ___ cfe-commits mailing lis

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:271 + static_assert(d.B::a == 12); + static_assert(d.C::a == 0); }; These lines are added by https://reviews.llvm.org/D143480 now, but the te

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder updated this revision to Diff 504146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Record.cpp clang/lib/AST/Interp/Record.h

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman added a comment. In D143466#4181191 , @tbaeder wrote: > The tests you proposed need https://reviews.llvm.org/D143480 first so we can > cast up more than one level. Okay, how about we land that one first then come back to this one? I left s

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder marked an inline comment as done. tbaeder added a comment. The tests you proposed need https://reviews.llvm.org/D143480 first so we can cast up more than one level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:260 + class _C : public _B {}; + constexpr _C c{12}; +}; We should test that the initialization actually happened. Comment at: clang/test/AST/Interp/records.cp

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the given test case, we were trying to initia