This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
benlangmuir marked an inline comment as done.
Closed by commit rGcf73d3f07b5b: [clang][deps] Ensure module invocation can be
serialized (authored by benlangmuir).
Repo
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143446/new/
https://reviews.llvm.org/D143446
___
cfe-commits maili
benlangmuir marked 3 inline comments as done.
benlangmuir added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:658
+#endif
+ if (RoundTripArgs.getNumOccurrences() ? RoundTripArgs : DoRoundTripDefault)
+if (FD.roundTripCommands(llvm::errs()))
-
benlangmuir updated this revision to Diff 495935.
benlangmuir added a comment.
- Improved doc comment for RoundTrip (mostly followed the suggested text; also
converted from // to ///).
- Renamed variables
- Moved default value for RoundTripArgs
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
jansvoboda11 added a comment.
Having this check is great! Left some nits in-line.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:644-650
// May perform round-trip of command line arguments. By default, the round-trip
// is enabled in assert builds. This can be overwrit
benlangmuir updated this revision to Diff 495573.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143446/new/
https://reviews.llvm.org/D143446
Files:
clang/include/clang/Frontend/CompilerInvocation.h
clang/lib/Basic/LangOptions.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/te
benlangmuir created this revision.
benlangmuir added reviewers: jansvoboda11, Bigcheese.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When reseting modular options, propagate the values from certa
