[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

mgorny added a comment. This commit broke building against `libclang-cpp.so` dylib. I've submitted a fix as D146427 but it haven't received any attention so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1434

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203525 , @dyung wrote: > In D143436#4203394 , > @DmitryPolukhin wrote: > >> @dyung I cannot reproduce this issue on two different machines in both cases >> tests work fine. For

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. In D143436#4203394 , @DmitryPolukhin wrote: > @dyung I cannot reproduce this issue on two different machines in both cases > tests work fine. For clang and llvm-jitlink binaries (the only binaries used > in the tests) my changes

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. In D143436#4203008 , @dyung wrote: > @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a > bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or > revert if you need time to inves

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

dyung added a comment. @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/247/builds/2639 TES

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

asb added a comment. This broke `-DBUILD_SHARED_LIBS=True` builds - I committed rG482d22d05a4a30a4f8594273bd359f7d311c9d4c to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGd60d3455eb2b: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D143436?vs=505030&id=506030#toc Repository: rG L

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet could you please take another look? I had to update diff to make it work when LLVM is configured without X86 targets so they are not valid and thus not injected into the command line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 505030. DmitryPolukhin added a comment. Update test to use any available target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clan

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. Had to revert this diff temporary due to broken ARM builds. It seems that X86 targets are disabled for that bots so tests are not passing. I'll fix upload new version for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rG34de7da6246c: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199 + // use/change working directory, which ExpandResponseFiles doesn't). + FS = llvm::vfs::getR

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504275. DmitryPolukhin added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.c

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet thank you for the review! Please take another look. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199 + // use/change working directory, which ExpandResponseFiles doesn't). + FS = llvm::vfs::getRealFileSystem(); +}

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504156. DmitryPolukhin marked 4 inline comments as done. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 File

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

kadircet added a comment. > @kadircet it is obvious that there is something in this diff that causes this > hesitancy in accepting it. I'm ready to keep iterating on the solution but I > need a clue what needs the improvement. Please comment. sorry for the late reply, i was on vacation and just

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet it is obvious that there is something in this diff that causes this hesitancy in accepting it. I'm ready to keep iterating on the solution but I need a clue what needs the improvement. Please comment. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet and @nridge friendly ping could you please accept this diff or let me know if you would like to change anything here? I moved `addTargetAndModeForProgramName` after `SystemIncludeExtractor` as was suggested. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 502110. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet friendly ping, could you please take a look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 ___ cfe-comm

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500620. DmitryPolukhin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500449. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 499766. DmitryPolukhin added a comment. Failing tests seems to be just flacky, I was not able to reprocuce any issue with them locally in stress runs and under ASan and TSan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r