This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG03ff435da540: [RISCV] Default to -ffixed-x18 for Fuchsia
(authored by mcgrathr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mcgrathr updated this revision to Diff 494972.
mcgrathr added a comment.
rebased, added clang driver test vs -fsanitize=shadow-call-stack
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143355/new/
https://reviews.llvm.org/D143355
Files:
clang/lib
MaskRay added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16
+#include "GISel/RISCVLegalizerInfo.h"
+#include "GISel/RISCVRegisterBankInfo.h"
#include "RISCV.h"
mcgrathr wrote:
> jrtc27 wrote:
> > Unrelated change
> arcanist requested i
mcgrathr updated this revision to Diff 494970.
mcgrathr added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143355/new/
https://reviews.llvm.org/D143355
Files:
clang/lib/Driver/SanitizerArgs.cpp
llvm/include/llvm/TargetParse
mcgrathr added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16
+#include "GISel/RISCVLegalizerInfo.h"
+#include "GISel/RISCVRegisterBankInfo.h"
#include "RISCV.h"
jrtc27 wrote:
> Unrelated change
arcanist requested it via clang-format
jrtc27 added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:16
+#include "GISel/RISCVLegalizerInfo.h"
+#include "GISel/RISCVRegisterBankInfo.h"
#include "RISCV.h"
Unrelated change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143355/new/
https://reviews.llvm.org/D143355
___
mcgrathr created this revision.
mcgrathr added reviewers: phosek, paulkirth, leonardchan.
Herald added subscribers: luke, VincentWu, abrachet, vkmr, frasercrmck,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,