[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-05-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for the patch, and sorry for the long delay. You probably need to do a large rebase when updating this patch (since the include-cleaner clangd code has been changed a lot) This is a big patch, touching several pieces (I'd suggest split this patch, and narrow its

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-22 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 499417. zyounan added a comment. Move parsing logic to Record.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-09 Thread Younan Zhang via Phabricator via cfe-commits
zyounan added a comment. In D143319#4115186 , @kadircet wrote: > thanks a lot for the patch! > > we're migrating IWYU related functionality in clangd to make use of > include-cleaner library nowadays. so can you actually move the IWYU > no_include pragm

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks a lot for the patch! we're migrating IWYU related functionality in clangd to make use of include-cleaner library nowadays. so can you actually move the IWYU no_include pragma handling logic into https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/i

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-07 Thread Younan Zhang via Phabricator via cfe-commits
zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-05 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 494921. zyounan added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-05 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 494911. zyounan added a comment. Herald added a subscriber: ormris. Update tests && Use Preprocessor.LookupFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-04 Thread Younan Zhang via Phabricator via cfe-commits
zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 494815. zyounan added a comment. zyounan updated this revision to Diff 494816. zyounan added reviewers: hokein, sammccall, kadircet, nridge. zyounan publis