[PATCH] D143305: [clang] Fix -Xarch_ for -mllvm and alike

2023-09-12 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl abandoned this revision. yaxunl added a comment. Abandon this patch unless we need it in the future. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143305/new/ https://reviews.llvm.org/D143305 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D143305: [clang] Fix -Xarch_ for -mllvm and alike

2023-08-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Herald added a subscriber: jplehr. I assume that this is unneeded after :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143305/new/ https://reviews.llvm.org/D143305

[PATCH] D143305: [clang] Fix -Xarch_ for -mllvm and alike

2023-02-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. An option value treating a space differently (as a delimiter in this case) is uncommon. I suggest an alias `-mllvm=` (D143325 ) which is more inline with the convention of the majority of options that take a value (`=` instead of ` `).

[PATCH] D143305: [clang] Fix -Xarch_ for -mllvm and alike

2023-02-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Curre