[PATCH] D143301: [flang] Handle unsupported warning flags

PeteSteinfeld added a comment. > @PeteSteinfeld, I think vzakhari's most recent commit > > fixes this. Thanks, @ elmcdonough, and @vzakhari! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4143241 , @PeteSteinfeld wrote: > In D143301#4143108 , @vzakhari > wrote: > >> The new tests fail to link: > > That is, these new tests cause check-flang to fail. @elmcdo

[PATCH] D143301: [flang] Handle unsupported warning flags

PeteSteinfeld added a comment. In D143301#4143108 , @vzakhari wrote: > The new tests fail to link: That is, these new tests cause check-flang to fail. @elmcdonough, can you please fix things so that check-flang no longer fails? Repository: rG LLVM

[PATCH] D143301: [flang] Handle unsupported warning flags

vzakhari added a comment. The new tests fail to link: flang-new: warning: The warning option '-Wextra' is not supported /usr/bin/ld: cannot find -lFortran_main /usr/bin/ld: cannot find -lFortranRuntime /usr/bin/ld: cannot find -lFortranDecimal Is the linking really necessary? Repositor

[PATCH] D143301: [flang] Handle unsupported warning flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce3a1c59e180: [flang] Handle unsupported warning flags (authored by elmcdonough). Changed prior to commit: https://reviews.llvm.org/D143301?vs=499

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for seeing this through! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 ___

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 499259. elmcdonough marked 3 inline comments as done. elmcdonough added a comment. Comment edit + exhuastive testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D14330

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:5045 +// Unsupported flang W options +defm : FlangIgnoredDiagOpt<"extra">; The name of the sub-project is "Flang", the sub-dir is "flang" and the driver name is "flang-new". Wh

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498944. elmcdonough added a comment. Clang format + documentation update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/Basic/Diagno

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough added a comment. In D143301#4135301 , @awarzynski wrote: > @elmcdonough , let me rephrase this (should've been clearer before, sorry): > >> One thing that's not clear to me - how come "-Wextra" is not treated as an >> error and "-Wblah" is?

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498511. elmcdonough marked an inline comment as done. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/cla

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added a comment. @elmcdonough , let me rephrase this (should've been clearer before, sorry): > One thing that's not clear to me - how come "-Wextra" is not treated as an > error and "-Wblah" is? Where's the logic that makes sure that `-Wextra` (and other flags that you redefine here

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498164. elmcdonough added a comment. Change multiclass name for the sake of clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/

[PATCH] D143301: [flang] Handle unsupported warning flags

awarzynski added a comment. Thanks for the update! One thing that's not clear to me - how come "-Wextra" **is not** treated as an error and "-Wblah" **is**? That's not clear from the code. I'm also realising that I incorrectly assumed that `-Wextra` was defined in Options.td. Instead, it's def

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 497405. elmcdonough retitled this revision from "Emit warning for unsupported gfortran flags" to "[flang] Handle unsupported warning flags". elmcdonough edited the summary of this revision. Herald added a subscriber: sunshaoce. Repository: rG LLVM Githu