This revision was automatically updated to reflect the committed changes.
Closed by commit rL256939: Show inclusions from a preamble in
clang_getInclusions. (authored by erikjv).
Changed prior to commit:
http://reviews.llvm.org/D14329?vs=39187&id=44120#toc
Repository:
rL LLVM
http://reviews
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Comment at: tools/libclang/CIndexInclusionStack.cpp:32
@@ -36,13 +31,3 @@
SmallVector InclusionStack;
- unsigned n = SM.local_sloc_entry_size(
skalinichev added a subscriber: skalinichev.
skalinichev added a comment.
I've seen this bug too. Generally this patch looks good to me.
Could you also add a test for includes half-way through a file case?
Comment at: tools/c-index-test/c-index-test.c:1567
@@ -1564,1 +1566,3 @@
erikjv created this revision.
erikjv added a reviewer: klimek.
erikjv added a subscriber: cfe-commits.
When reparsing a translation unit with preamble generation turned on,
no includes are found. This is due to the fact that all SLocs from
AST/PCH files are skipped as they are 'loaded', and inclus
