[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG58927e993121: [clangd] Remove the direct use of StdSymbolMapping.inc usage. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D143274?vs=49

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:43 + /// Returns the overridden include for a qualified symbol with, or "". + /// \p Scope and \p Name concatenation forms the full qualified name. + /// \p Scope is the qualifier wi

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495096. hokein marked an inline comment as done. hokein added a comment. refined the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-extr

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein marked an inline comment as done. hokein added a comment. In D143274#4106449 , @kadircet wrote: > thanks a lot. since this is the last (and only) upstream user of the raw > mappings. can you also move them into `clang/lib/Tooling/Inclusions/Stdlib

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added a comment. thanks a lot. since this is the last (and only) upstream user of the raw mappings. can you also move them into `clang/lib/Tooling/Inclusions/Stdlib/` as part of this patch? Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:43 + /// Retu

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495066. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-extr

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495065. hokein marked 2 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https://reviews.llvm.org/D143274 Files: clang-tools-e

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:711 +return ""; + // There are multiple headers for size_t, pick one. + if (QName == "std::size_t") i think the comment is misleading. as if we had some alterna

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736 void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) { if (Language.CPlusPlus) { +static const auto *Symbols = []() { kadircet wrote

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein updated this revision to Diff 495036. hokein marked an inline comment as done. hokein added a comment. address review comment: remove StdSymbolMapping in the CanonicalIncluedes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143274/new/ https

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736 void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) { if (Language.CPlusPlus) { +static const auto *Symbols = []() { what about g

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Replace them with the lib