sammccall added a comment.
Code looks reasonable, but I don't understand why the changes are being made -
can you explain/link to a bug in the commit message?
Comment at: clang-tools-extra/clangd/Preamble.cpp:688
if (It != ExistingIncludes.end()) {
-Inc.Resolved
kadircet updated this revision to Diff 494347.
kadircet added a comment.
- Also populate additional fields
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143197/new/
https://reviews.llvm.org/D143197
Files:
clang-tools-extra/clangd/Preamble.cpp
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
