[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders added a comment. (ping) Does this make sense or are more adjustments needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143112/new/ https://reviews.llvm.org/D143112 ___ cfe-commits mailing

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang/lib/AST/RawCommentList.cpp:227 + SourceMgr.getLocForStartOfFile(SourceMgr.getMainFileID()), + Allocator, SourceMgr.getDiagnostics(), Traits)

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders updated this revision to Diff 498586. tom-anders added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. - Move to free function in CodeCompletionStrings.h - Add back comment markers before parsing (Index stores comments without markers, but the

[PATCH] D143112: [clang] Support parsing comments without ASTContext

kadircet added a comment. Thanks, this looks like a good start. I left some comments about the details of implementation, as for placing and APIs in general, i think it's useful to see how things will be built on top inside clangd to make the right call here. Comment at: clan

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:159 + /// Parse the \p Comment, storing the result in \p Allocator + static comments::FullComment *parse(llvm::StringRef Comment, + llvm::BumpPtrAllocator

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders created this revision. tom-anders added a reviewer: kadircet. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This is in preparation for implementing doxygen parsing, see disc