This revision was automatically updated to reflect the committed changes.
Closed by commit rG909cd1f9a893: [clangd] Respect preamble-patch when handling
diags (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143095/new/
https://
kadircet updated this revision to Diff 495893.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Drop FIXME for respecting all presumed locations
- Use PatchLoc instead of PLoc
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:102
+ auto PatchedRange = [&M](CharSourceRange &R) {
+// FIXME: Should we handle all presumed locations?
+
kadircet updated this revision to Diff 495410.
kadircet added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143095/new/
https://reviews.llvm.org/D143095
Files:
clang-tools-extra/clangd/Diagnostics.cpp
clang-tools-extra/clan
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Depends on D
