This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab2c80bb1256: [Driver] BareMetal ToolChain multilib layering
(authored by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
michaelplatings updated this revision to Diff 529567.
michaelplatings added a comment.
Simplify code as suggested by @phosek
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolC
phosek accepted this revision.
phosek added a comment.
LGTM
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:236-240
+ if (!SelectedMultilibs.empty()) {
+return llvm::iterator_range<
+llvm::SmallVector::const_reverse_iterator>(
+SelectedMultilibs.rbegi
michaelplatings added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246
+ // No multilibs selected so return a single default multilib.
+ static llvm::SmallVector Default = {Multilib()};
+ return llvm::iterator_range<
+ llvm::SmallVector::cons
michaelplatings updated this revision to Diff 529318.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246
+ // No multilibs selected so return a single default multilib.
+ static llvm::SmallVector Default = {Multilib()};
+ return llvm::iterator_range<
+ llvm::SmallVector::const_reverse
michaelplatings added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228
+
+llvm::SmallVector BareMetal::getOrderedMultilibs() const {
+ // Get multilibs in reverse order because they're ordered most-specific last.
phosek wrote:
> Can you
michaelplatings updated this revision to Diff 529021.
michaelplatings marked an inline comment as done.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
cla
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228
+
+llvm::SmallVector BareMetal::getOrderedMultilibs() const {
+ // Get multilibs in reverse order because they're ordered most-specific last.
Can you use
[llvm::reverse](htt
michaelplatings updated this revision to Diff 519003.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
michaelplatings updated this revision to Diff 508040.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
michaelplatings updated this revision to Diff 505290.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
michaelplatings updated this revision to Diff 505052.
michaelplatings added a comment.
tags->flags
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clan
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
I've set approved from the Arm side. Please leave some time for people in the
US time zone to leave any final comments or ask for extensions.
Repository:
rG LLVM Github Monorepo
michaelplatings updated this revision to Diff 503905.
michaelplatings added a comment.
flags -> tags
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
cl
michaelplatings updated this revision to Diff 499962.
michaelplatings added a comment.
PrintArgs -> PrintOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMe
michaelplatings updated this revision to Diff 499503.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
michaelplatings updated this revision to Diff 499491.
michaelplatings added a comment.
Rebase and remove some braces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/Ba
peter.smith added a comment.
No comments on the implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
___
cfe-commits mailing list
cfe-commits@lists.l
michaelplatings updated this revision to Diff 495559.
michaelplatings added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/lib
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added a subscriber: abidh.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
This enables layering ba
21 matches
Mail list logo
