This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa7fbca40805c: [NFC] Extract `CodeGenInstAlias` into its own
*.h/*.cpp (authored by barannikov88).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142968/new/
https://reviews.llvm.org/D142968
__
barannikov88 added a comment.
I intent to make make InstAlias with "complex" operands (non-empty
MIOperandInfo) more robust (stricter syntax).
The change will clobber most of the code here, and I thought it is a good time
to move the class to a dedicated file.
Another weak point is that this cla
foad added inline comments.
Comment at: clang/docs/tools/clang-formatted-files.txt:7421
llvm/utils/not/not.cpp
+llvm/Utils/TableGen/CodeGenInstAlias.cpp
+llvm/Utils/TableGen/CodeGenInstAlias.h
Should come after CodeBeads in alphabetical order?
Repository:
rG
foad added a comment.
Looks OK but what's the motivation for it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142968/new/
https://reviews.llvm.org/D142968
___
cfe-commits mailing list
cfe-commits@lists.
barannikov88 created this revision.
Herald added a subscriber: jeroen.dobbelaere.
Herald added a project: All.
barannikov88 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Repository:
rG LLVM Github Monorepo
https://rev
