[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm closed this revision. arsenm added a comment. 8e009348e8a2e9c4577538eba6ca5c6cb286776f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 __

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! > The __builtin_align_{up,down} code generation could also make use of this > IIRC. I think the reason I didn't do this initially was concerns about > ptrmask not being optimized

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arichardson added a comment. The `__builtin_align_{up,down}` code generation could also make use of this IIRC. I think the reason I didn't do this initially was concerns about ptrmask not being optimized as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://review

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499799. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c clang/test/CodeGen/a

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499798. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/arm-abi-vector.c clang/test/CodeGen/a

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm updated this revision to Diff 499797. arsenm added a comment. Test updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/PowerPC/ppc-varargs-struct.c clang/test/CodeGen/

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn added a comment. Using `ptrmask` here looks good to me, but it looks like a couple of tests need still updating; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 ___ cfe-commits mailing list cf

[PATCH] D142934: clang: Use ptrmask for pointer alignment

arsenm created this revision. arsenm added reviewers: spetrovic, nemanjai, rjmccall, hfinkel, fhahn. Herald added subscribers: StephenFan, kbarton, arichardson. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Avoid using ptrtoint/inttoptr.