This revision was automatically updated to reflect the committed changes.
michaelplatings marked 4 inline comments as done.
Closed by commit rG850dab0f2537: [NFC] Class for building MultilibSet (authored
by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/include/clang/Driver/MultilibBuilder.h:117
+ /// Add an optional Multilib segment
+ MultilibSetBuilder &Maybe(const MultilibBuilder &M);
+
--
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/MultilibBuilder.h:117
+ /// Add an optional Multilib segment
+ MultilibSetBuilder &Maybe(const MultilibBuilder &M);
+
Use `camelCase` for new function names.
Repository:
rG LLVM Github Mo
peter.smith added a comment.
Thanks for the updates, I'm happy with the changes and don't have any more
comments. Happy to give my implicit approval.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142893/new/
https://reviews.llvm.org/D142893
_
michaelplatings marked 4 inline comments as done.
michaelplatings added inline comments.
Comment at: clang/include/clang/Driver/Multilib.h:35-39
std::string GCCSuffix;
std::string OSSuffix;
std::string IncludeSuffix;
flags_list Flags;
int Priority;
michaelplatings updated this revision to Diff 495798.
michaelplatings added a comment.
Replace makeMultilibBuilder() with a MultilibBuilder constructor that
initializes all suffixes to the same value.
In the case of AndroidMipsMultilibs it was apparently intended that only the
GCC suffix was se
phosek added inline comments.
Comment at: clang/include/clang/Driver/Multilib.h:35-39
std::string GCCSuffix;
std::string OSSuffix;
std::string IncludeSuffix;
flags_list Flags;
int Priority;
Since this class is intended to be immutable, we should al
michaelplatings added inline comments.
Comment at: clang/include/clang/Driver/Multilib.h:25
namespace driver {
/// This corresponds to a single GCC Multilib, or a segment of one controlled
peter.smith wrote:
> It took a bit of reading to work out what the rel
michaelplatings updated this revision to Diff 495460.
michaelplatings marked 6 inline comments as done.
michaelplatings added a comment.
Apply improvements suggested by @peter.smith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142893/new/
https://
peter.smith added a comment.
Looks good so far. Some stylistic suggestions.
Comment at: clang/include/clang/Driver/Multilib.h:25
namespace driver {
/// This corresponds to a single GCC Multilib, or a segment of one controlled
It took a bit of reading to wor
10 matches
Mail list logo
