This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c4691391419: [clangd] Semantic highlighting for
constrained-parameter (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
nridge updated this revision to Diff 495015.
nridge added a comment.
address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142871/new/
https://reviews.llvm.org/D142871
Files:
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-e
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:1047
+ bool TraverseTypeConstraint(const TypeConstraint *TC) {
+Out(ReferenceLoc{TC->getNestedNameSpecifier
nridge added a comment.
Also filed https://github.com/llvm/llvm-project/issues/60469 for the seemingly
missing RecursiveASTVisitor methods
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142871/new/
https://reviews.llvm.org/D142871
nridge updated this revision to Diff 494172.
nridge added a comment.
Address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142871/new/
https://reviews.llvm.org/D142871
Files:
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-e
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:720
+ // Pick up the name via VisitNamedDecl
+ Base::VisitTemplateTypeParmDecl(D);
+}
kadircet wrote:
> nridge wrote:
> > Am I using the API correctly here? It's a
kadircet added a subscriber: usaxena95.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:720
+ // Pick up the name via VisitNamedDecl
+ Base::VisitTemplateTypeParmDecl(D);
+}
nridge wrote:
> Am I using the API corr
nridge added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:720
+ // Pick up the name via VisitNamedDecl
+ Base::VisitTemplateTypeParmDecl(D);
+}
Am I using the API correctly here? It's a bit weird that `ConstDeclVisitor`
woul
nridge created this revision.
nridge added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LL
