[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. Should be fixed by https://github.com/llvm/llvm-project/commit/108fa70cd213e63a591adb87ce444fb74afc6786 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 _

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. In D142757#4100167 , @thakis wrote: > This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for reporting. It seems I should have added

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D14275

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe082124faa8: [clang][driver] Emit an error for `/clang:-x` (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://revie

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494222. Fznamznon added a comment. Fix incorrect conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/li

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494221. Fznamznon added a comment. Apply suggestion and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driv

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did yo

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: u

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. @MaskRay , thanks for the suggestions. Applied. Please let me know that it is ok now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 __

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix confusing warning message when `/clang:-x` is passed in clang-cl driver + mode and emit an error which suggests using `/TC` o

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"); } MaskRay wrote: > Fz

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493576. Fznamznon added a comment. Apply suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"); } Fznamznon wrote: > Ma

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay added a comment. > In CL mode values of /clang: arguments end up at the end of arguments list so > passing /clang:-x doesn't make sense and produces confusing warning. The description needs updating. `clang:-x` emits an error instead of a warning. And if the error is suppressed, `/clan

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix confusing warning message when `/clang:-x` is

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493326. Fznamznon added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Drive

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

aaron.ballman added a comment. This seems reasonable to me. I was a bit worried about the behavior being rather strange, but given that these are "escape hatch" command line options to skip the clang-cl driver, and there are existing clang-cl options that cover this functionality, it makes more

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"