[PATCH] D142733: Add _Optional as fast qualifier

2023-01-29 Thread Christopher Bazley via Phabricator via cfe-commits
chrisbazley added a comment. Hi, thanks very much for looking at my patch. I added the link that you proposed to all of the patches in the stack. > Assuming that we want to go in this direction, it seems quite expensive to > model this as a fast qualifier rather than an extended qualifier. Tru

[PATCH] D142733: Add _Optional as fast qualifier

2023-01-29 Thread Christopher Bazley via Phabricator via cfe-commits
chrisbazley added a comment. Please refer to https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/ and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider context of this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142733: Add _Optional as fast qualifier

2023-01-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Including a link to the RFC (https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/68004/2) in each of the patches in this series would be helpful. Assuming that we want to go in this direction, it seems quite expensive to model this

[PATCH] D142733: Add _Optional as fast qualifier

2023-01-27 Thread River Riddle via Phabricator via cfe-commits
rriddle added a comment. I don't understand the MLIR changes here, how are they relevant to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142733/new/ https://reviews.llvm.org/D142733 ___ cfe-c

[PATCH] D142733: Add _Optional as fast qualifier

2023-01-27 Thread Christopher Bazley via Phabricator via cfe-commits
chrisbazley created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,