rmaz added inline comments.
Comment at: clang/lib/Lex/ModuleMap.cpp:663
Result->IsInferred = true;
- Result->addTopHeader(File);
+ Result->addTopHeader(File->getLastRef());
jansvoboda11 wrote:
> rmaz wrote:
> > jansvoboda11 wrote:
> > > How muc
jansvoboda11 added inline comments.
Comment at: clang/lib/Lex/ModuleMap.cpp:663
Result->IsInferred = true;
- Result->addTopHeader(File);
+ Result->addTopHeader(File->getLastRef());
rmaz wrote:
> jansvoboda11 wrote:
> > How much work would be to
rmaz marked an inline comment as done.
rmaz added inline comments.
Comment at: clang/lib/Lex/ModuleMap.cpp:663
Result->IsInferred = true;
- Result->addTopHeader(File);
+ Result->addTopHeader(File->getLastRef());
jansvoboda11 wrote:
> How much w
rmaz updated this revision to Diff 492829.
rmaz added a comment.
Use FileEntryRef for AddTopHeader()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142724/new/
https://reviews.llvm.org/D142724
Files:
clang/include/clang/Basic/Module.h
clang/lib
jansvoboda11 added inline comments.
Comment at: clang/lib/Basic/Module.cpp:273
+void Module::addTopHeader(OptionalFileEntryRef File) {
assert(File);
+ TopHeaders.insert(*File);
If we assert that `File` is not empty right away, why take
`OptionalFileEntryRef`
rmaz created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
rmaz requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Refactor a Module's TopHeaders to use FileEntryRef. This will keep
the paths serialized in a
