[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

This revision was automatically updated to reflect the committed changes. Closed by commit rG61fee67cd77a: [Clang][Driver] Handle LoongArch multiarch tuples (authored by WANG Xuerui , committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining accepted this revision. SixWeining added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ -

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ SixWeining wrote: > Better to use “loongarch64” when talking about debian? Refer > h

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:247 // +// Check header search on Debian loong64 +// RUN: %clang -### %s -fsyntax-only 2>&1 \ Better to use “loongarch64” when talking about debian? Refer https://wiki.debia

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n marked 2 inline comments as done. xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &Ta

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 510333. xen0n marked an inline comment as done. xen0n added a comment. Rebase and add tests, also use Twine for concatenating strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n marked 5 inline comments as done. xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:66 + default: +return IsLA32 ? "ilp32d" : "lp64d"; + } xry111 wrote: > SixWeining wrote: > > Better to be `f`? (Probably most 32-

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 510320. xen0n added a comment. Rebase and reflect the Toolchain Conventions change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 Files: clang/lib/Driver/ToolChains

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xry111 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:66 + default: +return IsLA32 ? "ilp32d" : "lp64d"; + } SixWeining wrote: > Better to be `f`? (Probably most 32-bit hardwares do not support > double-float? But I'm not

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:66 + default: +return IsLA32 ? "ilp32d" : "lp64d"; + } Better to be `f`? (Probably most 32-bit hardwares do not support double-float? But I'm not sure about this.)

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &TargetTriple, SixWeining

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 493796. xen0n added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 Files: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp clang/lib/Driver/ToolCha

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:116 + +return std::string("loongarch64-linux-") + Libc + FPFlavor; + } `return (... + ...).str();` if an operand of `+` is a `Twine` Repository: rG LLVM Github Monorepo CHA

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &TargetTriple, Missin

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n created this revision. xen0n added reviewers: SixWeining, wangleiat, MaskRay, xry111. Herald added a project: All. xen0n requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This follows v1.00 of the LoongArch Toolchain Conventions