[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494675. KyleFromKitware added a comment. Added virtual destructor to `HeaderGuardStyle`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h cl

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/llvm/CMakeLists.txt clang-tools-extra/clang-tidy/llvm/

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware added a comment. In D142673#4086018 , @carlosgalvezp wrote: > Note: I do not have possibility to add code comments - is there some too > strict permissions set for this patch? It has not happened to other patches. I accidentally set the

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Also, in general the design choice is that checks should be independent and authors should not need to care about whether they conflict with other checks. In this particular case, if both checks are providing different results, users should choose one and disable

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

carlosgalvezp added a comment. Note: I do not have possibility to add code comments - is there some too strict permissions set for this patch? It has not happened to other patches. Review comment: I think the design choice in clang-tidy is that checks from different modules should not depend o

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 492633. KyleFromKitware changed the edit policy from "All Users" to "Only User: KyleFromKitware (Kyle Edwards)". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: sscalpone. Herald added a reviewer: njames93. Herald added a project: All. Kyl