[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-25 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D142506#4078532 , @scchan wrote: > In D142506#4078402 , @arsenm wrote: > >> The resource directory should be strictly controlled. why would lib64 ever >> be used here? > > The intention

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-25 Thread Siu Chi Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56184bb3ad3f: [AMDGCN] Fix device lib test to work with lib64 (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-24 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan added a comment. In D142506#4078402 , @arsenm wrote: > The resource directory should be strictly controlled. why would lib64 ever be > used here? The intention is to eventually move the device libs into the library directory inside clang's resou

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. The resource directory should be strictly controlled. why would lib64 ever be used here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142506/new/ https://reviews.llvm.org/D142506 __

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142506/new/ https://reviews.llvm.org/D142506 __

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

2023-01-24 Thread Siu Chi Chan via Phabricator via cfe-commits
scchan created this revision. scchan added reviewers: yaxunl, mgorny. Herald added subscribers: kosarev, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes an issue introduced by h