[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. In D142500#4080317 , @erichkeane wrote: > In D142500#4080302 , @erichkeane > wrote: > >> In D142500#4080279 , @Mordante >> wrote: >> >>> In D1

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a subscriber: mstorsjo. erichkeane added a comment. In D142500#4080302 , @erichkeane wrote: > In D142500#4080279 , @Mordante > wrote: > >> In D142500#4079669

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D142500#4080279 , @Mordante wrote: > In D142500#4079669 , @erichkeane > wrote: > >> In D142500#4079135 , @Mordante >> wrote: >> >>> FYI I

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. In D142500#4079669 , @erichkeane wrote: > In D142500#4079135 , @Mordante > wrote: > >> FYI I tested this patch with libc++ and as expected it does not fix the >> libc++ modular build I

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Erich Keane via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG228462f755f0: Fix one of the regressions found in revert of concept sugaring (authored by erichkeane). Herald added a project: clang. Repository:

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D142500#4079135 , @Mordante wrote: > FYI I tested this patch with libc++ and as expected it does not fix the > libc++ modular build ICE. A man can dream, eh? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/n

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-25 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for preparing this fix! I've verified that it fixes the original reproducer as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

2023-01-24 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500 ___ cfe-commits mailing li