[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added a comment. Thx @efriedma for reminding me of this. I'll update the documentation and try to give a shot at removing `MaybeAlign` from `GlobalObject`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142459/new/ https://reviews.llvm.or

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrO

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOr

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valu

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valu

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

tra added a subscriber: yaxunl. tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); +

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOr

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne(),

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

courbet added inline comments. Comment at: clang/include/clang/AST/CharUnits.h:73 + /// fromQuantity - Construct a CharUnits quantity from an llvm::Align + /// quantity. `Maybe`* Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1991 +

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: All. gchatelet requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This remove the last uses of GlobalObject::getAlignment and marks