[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

2023-02-01 Thread Usama Hameed via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57690a8ece9e: [Sanitizers] fix -fno-sanitize-link-runtime for darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

2023-01-26 Thread Roy Sundahl via Phabricator via cfe-commits
rsundahl accepted this revision. rsundahl added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142421/new/ https://reviews.llvm.org/D142421 ___ cfe-commits mailing list cfe-commit

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

2023-01-26 Thread Brittany Blue Gaston via Phabricator via cfe-commits
thetruestblue accepted this revision. thetruestblue added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142421/new/ https://reviews.llvm.org/D142421 ___ cfe-commits mailing list cfe-commi

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

2023-01-26 Thread Julian Lettner via Phabricator via cfe-commits
yln added a comment. Looks harmless enough, even though I am not sure why we have a completely separate code path on Darwin. The other toolchain driver seem to have shared code for this in `clang/lib/Driver/ToolChains/CommonArgs.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

2023-01-23 Thread Usama Hameed via Phabricator via cfe-commits
usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. rdar://99200922 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142421 Files: clang/lib/