[PATCH] D142416: [clang][deps] NFC: Remove dead code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbeebad9a9b23: [clang][deps] NFC: Remove dead code (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D142416: [clang][deps] NFC: Remove dead code

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). - CI.getHeaderS

[PATCH] D142416: [clang][deps] NFC: Remove dead code

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). - CI.getHeaderSearchOpts().ModulesStrictContextHash = true; - benlangmuir wrote: >

[PATCH] D142416: [clang][deps] NFC: Remove dead code

benlangmuir added a comment. Removing `ImplicitModulePCMPath` LGTM; not sure about the other change. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:180 - // incompatible modules (e.g. with differences in search paths). - CI.getHeaderSearchOpts().Modul

[PATCH] D142416: [clang][deps] NFC: Remove dead code

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some dead code