[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-04-13 Thread Philipp Tomsich via Phabricator via cfe-commits
philipp.tomsich abandoned this revision. philipp.tomsich added a comment. I just saw that the last response was "unsubmitted". Submitting and abandoning this revision (based on the discussion and the previously unsubmitted comment from my end). Comment at: llvm/include/llvm/T

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-03-24 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. @philipp.tomsich Reverse Ping. What are your plans for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142410/new/ https://reviews.llvm.org/D142410 ___ cfe-commits mail

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-01-24 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. In D142410#4076389 , @philipp.tomsich wrote: > When looking at "ARM DDI 0487G.a", on page A2-68 under the heading > "Additional functionality added to Armv8.0 in later releases" in the > definition-list item "FEAT_SSBS, Speculat

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-01-24 Thread Philipp Tomsich via Phabricator via cfe-commits
philipp.tomsich added a comment. When looking at "ARM DDI 0487G.a", on page A2-68 under the heading "Additional functionality added to Armv8.0 in later releases" in the definition-list item "FEAT_SSBS, Speculative Store Bypass Safe": > This feature is OPTIONAL in Armv8.0 implementations and man

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-01-24 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. SSBS is not mandatory from v8.5a onwards. More details/citation inline. NB: This will need a rebase, because @dmgreen changed how crypto is handled in these bitmaps yesterday. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:311 inline

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-01-24 Thread Dave Green via Phabricator via cfe-commits
dmgreen added reviewers: lenary, tmatheson, pratlucas. dmgreen added a comment. I believe this is correct, according to at least one reference I have. FEAT_SSBS isn't spelled out very clearly in the reference manual though. Adding some more people who might be able to check. Repository: rG L

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

2023-01-23 Thread Philipp Tomsich via Phabricator via cfe-commits
philipp.tomsich created this revision. philipp.tomsich added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi