This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfb0af89193a9: [AArch64] Add the Ampere1A core (authored by
philipp.tomsich).
Changed prior to commit:
https://reviews.llvm.org/D142396?vs=491840&i
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
OK Thanks for the clarification. LGTM then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142396/new/
https://reviews.llvm.org/D142396
__
philipp.tomsich updated this revision to Diff 491840.
philipp.tomsich added a comment.
- untabify on some tabs that slipped in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142396/new/
https://reviews.llvm.org/D142396
Files:
clang/test/Misc/targ
philipp.tomsich added inline comments.
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492
+{"ampere1a", ARMV8_6A,
+ (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 |
+ AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES |
dmgreen added inline comments.
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492
+{"ampere1a", ARMV8_6A,
+ (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 |
+ AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES |
Jus
philipp.tomsich updated this revision to Diff 491738.
philipp.tomsich added a comment.
- Split off new (Ampere1A-specific) fusion case
- Updated the Ampere1A SubtargetFeature list to include (hopefully) all features
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
dmgreen added a comment.
Sounds OK, but do you mind splitting FeatureFuseAddSub2RegAndConstOne into a
separate patch. They seem to be logically separable, and it can help in case
there are problems found in one of the patches.
Comment at: llvm/include/llvm/TargetParser/AArch6
philipp.tomsich updated this revision to Diff 491499.
philipp.tomsich added a comment.
v2 changes:
- fixes a whitespace issue
- fixes a rebase artifact on Ampere1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142396/new/
https://reviews.llvm.org/D
philipp.tomsich created this revision.
philipp.tomsich added a reviewer: dmgreen.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
philipp.tomsich requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commi
