[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") ManuelJBrito wrote: > ManuelJBrito wrote: > > ManuelJBrito wrote: > > > eri

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito updated this revision to Diff 491783. ManuelJBrito added a comment. fixed diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/include/clang/Basic/Builtins.def clang/include/

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito added a comment. Oops wrong diff, i'll update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito updated this revision to Diff 491767. ManuelJBrito added a comment. Add tests with bool and bool-vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/test/CodeGen/builtins-no

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CodeGen/builtins-nondet.c:3 + +typedef float float4 __attribute__((ext_vector_type(4))); + ManuelJBrito wrote: > shafik wrote: > > erichkeane wrote: > > > Add some examples for 'bool' and vector-bool as wel

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-24 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > shaf

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-23 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") aaron.ballman wrote: > aaron.ballman wrote: > > shafik wrote: > > > erichkeane

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Be sure to add documentation for this to the language extensions page and mention the new builtin in the release notes. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__built

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-23 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > Not a fan of the name in general, it doesn't really explain wh

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-23 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") Not a fan of the name in general, it doesn't really explain what is happening.

[PATCH] D142388: [clang] Add builtin_nondet

2023-01-23 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito created this revision. ManuelJBrito added reviewers: aaron.ballman, erichkeane, shafik. ManuelJBrito added a project: clang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits. This patch adds a builtin that returns a no