[PATCH] D142187: [clang] Fix typos in member initializers

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4101 - ExprResult Init = InitExpr; - if (!FD->getType()->isDependentType() && !InitExpr->isTypeDependent()) { -Init = ConvertMemberDefaultInitExpression(FD, InitExpr, InitLoc); + ExprResult I

[PATCH] D142187: [clang] Fix typos in member initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebd9a2477e69: [clang] Fix typos in member initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D142187: [clang] Fix typos in member initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142187/new/ https://reviews.llvm.org/D142187

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet updated this revision to Diff 490793. kadircet marked 3 inline comments as done. kadircet added a comment. assert on usability of initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142187/new/ https://reviews.llvm.org/D142187 Files

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4101 - ExprResult Init = InitExpr; - if (!FD->getType()->isDependentType() && !InitExpr->isTypeDependent()) { -Init = ConvertMemberDefaultInitExpression(F

[PATCH] D142187: [clang] Fix typos in member initializers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4103 + /*RecoverUncorrectedTypos=*/true); + if (!FD->getType()->isDependentType() && !Init.get()->isTypeDependent()) { +Init = ConvertMemberDefaultIn

[PATCH] D142187: [clang] Fix typos in member initializers

hokein added a comment. In D142187#4068092 , @ilya-biryukov wrote: > Randomly chiming in here. > I never had a good model of where `CorrectDelayedTyposInExpr`, but wanted to > note that `ActOnFullExpr` also calls it. This may be fine, I just wanted to

[PATCH] D142187: [clang] Fix typos in member initializers

ilya-biryukov added a comment. Randomly chiming in here. I never had a good model of where `CorrectDelayedTyposInExpr`, but wanted to note that `ActOnFullExpr` also calls it. This may be fine, I just wanted to mention it as it stood out. Comment at: clang/lib/Sema/SemaDeclCXX

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet created this revision. kadircet added reviewers: hokein, cor3ntin, aaron.ballman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was regressed in ca619613801233ef2def8c3cc7d311d5ed0033cb