[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz abandoned this revision. rmaz added a comment. Its going to be less work to refactor TopheaderNames to use FileEntryRef, so went that way instead. First step is here: https://reviews.llvm.org/D142113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz added a comment. In D142028#4062798 , @akyrtzi wrote: > Is it reasonable to at least have an alternative implementation for it (e.g. > from the module headers find the headers that were not included from other > headers), not sure if it'd be straig

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

akyrtzi added a comment. This is useful for functionality, like in an IDE, to show the top headers of a module import for navigational purposes. Is it reasonable to at least have an alternative implementation for it (e.g. from the module headers find the headers that were not included from other

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz added a comment. @akyrtzi it looks like you added this field a while back. Do you know if there are still consumers for the the libclang API, do we need to keep this field around? The alternative is to refactor the `TopHeaders` set to use `FileEntryRef` so that we can keep track of the co

[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

rmaz created this revision. Herald added a subscriber: arphaman. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are seeing issues with path serialization of the `SUBMODULE_TOPHEADER` field when the inpu