This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG65cf77d218cf: [clang] Use FP options from AST for emitting
code for casts (authored by sepavloff).
Repository:
rG LLVM Github Monorepo
CHANGES SI
sepavloff added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142001/new/
https://reviews.llvm.org/D142001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142001/new/
https://reviews.llvm.org/D142001
__
sepavloff updated this revision to Diff 490504.
sepavloff added a comment.
Use --implicit-check-not in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142001/new/
https://reviews.llvm.org/D142001
Files:
clang/lib/CodeGen/CGExprScalar.cpp
c
rjmccall added a comment.
Overall looks reasonable. One question about testing.
Comment at: clang/test/CodeGen/X86/avx512dq-builtins-constrained.c:7
-// FIXME: Every instance of "fpexcept.maytrap" is wrong.
+// Any cases of "fpexcept.maytrap" in this test are clang bugs.
+
-
sepavloff created this revision.
sepavloff added reviewers: rjmccall, kpn, aaron.ballman.
Herald added a subscriber: pengfei.
Herald added a project: All.
sepavloff requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D14
