[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

smeenai added a comment. In D141918#4577930 , @jyknight wrote: > In D141918#4566838 , @smeenai wrote: > >> $ clang -std=c++20 -O2 -c crash.cpp >> cannot use musttail with unwindabort > > Thanks for the report. We

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jyknight added a comment. In D141918#4566838 , @smeenai wrote: > $ clang -std=c++20 -O2 -c crash.cpp > cannot use musttail with unwindabort Thanks for the report. We were missing a check of `CI.isUnwindAbort()` in CoroSplit.cpp's `shouldBeMustTail()` fu

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

smeenai added a comment. Thanks for the rebase! We're eager to try this for Meta's Android apps, where size is a priority and better `noexcept` codegen would be really helpful. I ran into a crash with coroutines though, which blocks me from fully evaluating the size difference made by these ch

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jyknight updated this revision to Diff 546613. jyknight edited the summary of this revision. jyknight added a comment. Rebase patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141918/new/ https://reviews.llvm.org/D141918 Files: clang/lib/Code

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5391 if (FPtr->hasFnAttribute(llvm::Attribute::NoUnwind)) CannotThrow = true; + Is there coverage for a nounwind callee + an unwindabort call? Repository: rG LLVM Github

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

jroelofs added inline comments. Herald added a subscriber: jplehr. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2021 + /* Indicates whether we should generate calls using unwindabort, instead of a + * terminate landingpad, for the current EH Scope. */ + bool shouldUseUnwin

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

barannikov88 added a comment. I couldn't find an example of creating "resume unwindabort" in the patch series. Is it yet to be done? Could you show a source code example where such an instruction should be generated? (By the frontend or an IR pass.) I couldn't get it from the RFC. Repository: