This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
xingxue marked an inline comment as done.
Closed by commit rGb05fa4faf64d: [clang][driver][AIX] Add OpenMP runtime if
-fopenmp specified (authored by xingxue).
Changed
xingxue added inline comments.
Comment at: clang/test/Driver/aix-ld.c:1027
+// RUN:-fopenmp \
+// RUN: | FileCheck --check-prefix=CHECK-FOPENMP-OMP %s
+// CHECK-FOPENMP-OMP-NOT: warning:
daltenty wrote:
> nit: since the output for these tests are really
daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.
Some minor nits about how we can shorten the test, but otherwise LGTM
Comment at: clang/test/Driver/aix-ld.c:1027
+// RUN:-fopenmp \
+// RUN: | FileCheck --chec
xingxue updated this revision to Diff 490167.
xingxue added a comment.
Addressed comments.
- added test scenarios for option `fopenmp` in `clang/test/Driver/aix-ld.c`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141862/new/
https://reviews.llvm.o
daltenty added a comment.
Needs a test, I think we should add a couple of `-fopenmp=foo` run lines to
`clang/test/Driver/aix-ld.c` to verify that the correct linker options are
produced for each.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D14186
xingxue created this revision.
xingxue added reviewers: daltenty, cebowleratibm, kkwli0.
xingxue added a project: LLVM.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
xingxue requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Heral
