rengolin closed this revision.
rengolin added a comment.
r252463
Repository:
rL LLVM
http://reviews.llvm.org/D14184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
tinti marked 6 inline comments as done.
Comment at: lib/Driver/Tools.cpp:3415
@@ -3414,1 +3414,3 @@
+ if (Arg *A = Args.getLastArg(options::OPT_meabi)) {
+CmdArgs.push_back("-meabi");
Good point! Fixed.
Comment at: lib/Frontend/CompilerInv
tinti set the repository for this revision to rL LLVM.
tinti updated this revision to Diff 39596.
tinti marked an inline comment as done.
tinti added a comment.
- Add test for error check
- Change StringSwitch to use lllvm::EABI type
Repository:
rL LLVM
http://reviews.llvm.org/D14184
Files:
tinti removed rL LLVM as the repository for this revision.
tinti updated this revision to Diff 39579.
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvoc
rengolin added inline comments.
Comment at: lib/Driver/Tools.cpp:3415
@@ -3414,1 +3414,3 @@
+ CmdArgs.push_back("-meabi");
+ if (Arg *A = Args.getLastArg(options::OPT_meabi))
Shouldn't we only add the option if it was used in the command line?
===
tinti marked 2 inline comments as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:459
@@ +458,3 @@
+StringRef Value = A->getValue();
+bool Valid = llvm::StringSwitch(Value)
+ .Case("default", true)
This part of the code does not i
tinti updated this revision to Diff 39304.
tinti added a comment.
Clang format.
Repository:
rL LLVM
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerIn
tinti set the repository for this revision to rL LLVM.
tinti updated this revision to Diff 39108.
tinti added a comment.
- Clang format code.
- Update eabi names to match new LLVM patch.
Repository:
rL LLVM
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/cla
rengolin added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:458
@@ +457,3 @@
+StringRef Value = A->getValue();
+bool Valid = llvm::StringSwitch(Value)
+ .Case("default", true)
tinti wrote:
> tinti wrote:
> > compnerd wrote:
> > > I
tinti added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:458
@@ +457,3 @@
+StringRef Value = A->getValue();
+bool Valid = llvm::StringSwitch(Value)
+ .Case("default", true)
tinti wrote:
> compnerd wrote:
> > If `llvm::EABI::EABIVer
tinti added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:524
@@ +523,3 @@
+ .Case("5", llvm::EABI::Eabi5)
+ .Case("gnu", llvm::EABI::Gnu)
+ .Default(llvm::EABI::Default);
compnerd wrote:
> I'd really rather see this written in the LLVM
compnerd added a comment.
This looks like what I had in mind wrt use of `-meabi`.
Comment at: lib/CodeGen/BackendUtil.cpp:524
@@ +523,3 @@
+ .Case("5", llvm::EABI::Eabi5)
+ .Case("gnu", llvm::EABI::Gnu)
+ .Default(llvm::EABI::Default);
I'd reall
tinti removed rL LLVM as the repository for this revision.
tinti updated this revision to Diff 38803.
tinti added a comment.
Add context
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/T
rengolin added reviewers: jroelofs, t.p.northover.
rengolin added subscribers: jroelofs, t.p.northover.
rengolin added a comment.
You forgot to add the context. It makes a big difference in the driver code. :)
But overall, looks good to me.
@jroelofs @compnerd @t.p.northover, can you see anythin
15 matches
Mail list logo
