martell added a comment.
From what I can gather it made sense at the time of gcc 4.6 so I don't think
anyone is at fault :)
Repository:
rL LLVM
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
chapuni added a comment.
Sorry, I supposed someone removed it. It was really buggy in past.
Repository:
rL LLVM
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251930: Remove some legacy mingw-w64 gcc struct info
(authored by martell).
Changed prior to commit:
http://reviews.llvm.org/D14179?vs=38744&id=39067#toc
Repository:
rL LLVM
http://reviews.llvm.org/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Yeah, lgtm.
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
martell added a subscriber: chapuni.
martell added a comment.
Ohh wow thats dated Dec 12 2013
I assume this would be suitable for 3.7.x then also.
This was originally introduced by @chapuni in http://reviews.llvm.org/rL126186
No test case seems to be present for this so I think this should be good
Correct. I we just switched to the 4.7 abi in r197163.
Cheers,
Rafael
On 29 October 2015 at 12:25, Reid Kleckner wrote:
> rnk added a comment.
>
> Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall
> on 32bit, right? I think we can take a break for x64.
>
>
> http://re
rnk added a comment.
Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall on
32bit, right? I think we can take a break for x64.
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
awson added a subscriber: awson.
awson added a comment.
Btw, It is a terrible bug.
It is hard to imagine how much C++ code it renders broken on 64-bit mingw-w64
clang. For example, any of hashtable-using code doesn't work etc etc.
http://reviews.llvm.org/D14179
_
martell created this revision.
martell added a reviewer: rnk.
martell added a subscriber: cfe-commits.
GCC versions starting at 4.8+ conform to standard Windows 64-bit ABI.
Not quite sure if we should keep this to support mingw-w64 and gcc 4.6
Thoughts ?
Also it seems to fix:
https://llvm.org/bug
