[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm updated this revision to Diff 558095. arsenm added a comment. Drop bitcode auto upgrade handling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141700/new/ https://reviews.llvm.org/D141700 Files: clang/lib/CodeGen/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-enqueue-ker

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm added inline comments. Comment at: llvm/lib/IR/CMakeLists.txt:84 Demangle + TransformUtils + This introduces a circular dependency between LLVMCore and TransformUtils. Options are: 1. Move appendToUsed into Module 2. Don't bother with bitcode compati

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:520 +static llvm::StructType *getAMDGPUKernelDescriptorType(llvm::LLVMContext &C) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); + llvm::Type *Int16 = llvm::IntegerType::getInt16Ty(C);

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } kzhuravl wrote: > Do we really need/want to update code object v2? as long as the code is here

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

kzhuravl added a comment. Overall looks good. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } Do we really need/want to update code object v2? CHANGES SINCE LAST ACTION

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

sameerds added a comment. LGTM, to the extent that I can see that the change does what is advertised, and the ultimately emitted HSA metadata preserves the current contract with the runtime. A couple of tests can use a little more explanatory comments as noted. Comment at: c

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12581 + Mod, HandleTy, + /*isConstant=*/true, llvm::GlobalValue::InternalLinkage, + /*Initializer=*/RuntimeHandleInitializer, RuntimeHandleName, Just a cosmetical remark

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm updated this revision to Diff 489394. arsenm added a comment. Rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141700/new/ https://reviews.llvm.org/D141700 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel-linking.cl clang/test/Code

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12440 +/// AMDHSAKernelDescriptor.h) +static llvm::StructType *getKernelDescriptorType(llvm::LLVMContext &C) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); Is this AMDGPU targ

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm created this revision. arsenm added reviewers: yaxunl, t-tye, b-sumner, rampitec, AMDGPU, Anastasia, JonChesterfield, jhuber6. Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revisi