[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm closed this revision. arsenm added a comment. 647925648a0fde06b5b44086843f0d8f164a71df CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 __

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 ___ cfe-commits mailing list cfe-c

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381 +// GFX900-LABEL: define {{[^@]+}}@callee +// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] { +// GFX900-NEXT: entry:

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381 +// GFX900-LABEL: define {{[^@]+}}@callee +// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] { +// GFX900-NEXT: entry:

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141620/new/ https://reviews.llvm.org/D141620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl:26 +// SPIR32-SAME: (ptr addrspace(1) align 4 [[A:%.*]], ptr addrspace(1) align 4 [[B:%.*]], i32 [[I:%.*]]) #[[ATTR0:[0-9]+]] !kernel_arg_addr_space !2 !kernel_arg_access_q

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl:26 +// SPIR32-SAME: (ptr addrspace(1) align 4 [[A:%.*]], ptr addrspace(1) align 4 [[B:%.*]], i32 [[I:%.*]]) #[[ATTR0:[0-9]+]] !kernel_arg_addr_space !2 !kernel_arg_acces

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange; ya

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:53-57 -__attribute__((target("s-memtime-inst"))) -void test_target_features_func(global int *i) { - queue_t default_queue; - unsigned flags = 0; - ndrange_t ndrange; wh