This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG30f96a8fb451: [clang][Interp] Properly identify
not-yet-defined functions (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141591/new/
https://reviews.llvm.org/D141591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141591/new/
https://reviews.llvm.org/D141591
___
cfe-commits mailing list
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1486
bool IsBeingCompiled = Func && !Func->isFullyCompiled();
- bool WasNotDefined = Func && !Func->hasBody();
+ bool WasNotDefined = Func && !Func->isConstexpr() && !Func->hasBody();
-
shafik added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1486
bool IsBeingCompiled = Func && !Func->isFullyCompiled();
- bool WasNotDefined = Func && !Func->hasBody();
+ bool WasNotDefined = Func && !Func->isConstexpr() && !Func->hasBody();
--
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/functions.cpp:158-174
+struct F {
+ constexpr bool ok() const {
+return okRecurse();
+ }
+ constexpr bool okRecurse() const {
+return true;
+ }
aaron.ballman wrote:
> Should we have some
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/functions.cpp:158-174
+struct F {
+ constexpr bool ok() const {
+return okRecurse();
+ }
+ constexpr bool okRecurse() const {
+return true;
+ }
Should we have some similar tests in
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141591/new/
https://reviews.llvm.org/D141591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141591/new/
https://reviews.llvm.org/D141591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 489020.
tbaeder added a comment.
Just get the information whether the `Function` has a body directly from the
`FunctionDecl`. This fixes referencing member functions that are defined later.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141591/new/
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Since we now handle functions without a body as w
11 matches
Mail list logo
