[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

mgorny added a comment. In D141581#4072692 , @kwk wrote: > In D141581#4071617 , @thesamesam > wrote: > >> This is currently holding back further testing on our end which is >> concerning me a bit, especially as

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli updated this revision to Diff 491320. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. @mgorny, I have updated the patch according to the suggestions from @tstellar in https://reviews.llvm.

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

kwk added a comment. In D141581#4071617 , @thesamesam wrote: > This is currently holding back further testing on our end which is concerning > me a bit, especially as we approach the branch point. Could you revert this > please if a fix isn't imminent?

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

thesamesam added a comment. This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

kwk added a comment. @tstellar as you suspected, I had the following problem when building clang in standalone mode and your patch solved it for me. Thank you. -- Configuring done CMake Error at /usr/lib64/cmake/llvm/AddLLVM.cmake:536 (add_dependencies): The dependency target "RISCVTarge

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I spent some time looking at this. Rather than changing the dependency from RISCVTargetParserTableGen to LLVMTargetParser, I think the correct fix is to handle RISCVTargetParserTableGen in llvm/cmake/modules/LLVMConfig.cmake.in. alongside the intrinsics_gen, omp_gen,

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069123 , @tstellar wrote: > I don't think this is the correct way to specify dependencies if it's just an > issue of the header being included before a generated file it needs has been > generated. Are there oth

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I don't think this is the correct way to specify dependencies if it's just an issue of the header being included before a generated file it needs has been generated. Are there other places in the code where a generated header file is included by another header? Repo

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069078 , @tstellar wrote: > So, what's the actual dependency here? Do libBasic and libDriver just need > the header to be generated or does it actually need to link to the library? Just the header. Repository:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069053 , @tstellar wrote: > [...] > It's still not clear to me why LLVM_LINK_COMPONENTS does not work. Is > LLVMTargetParser a library? Yes, `LLVMTargetParser` is a library built located in `llvm/lib/TargetParse

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. So, what's the actual dependency here? Do libBasic and libDriver just need the header to be generated or does it actually need to link to the library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://rev

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. Is LLVMTargetParser a library In D141581#4057177 , @fpetrogalli wrote: > In D141581#4056825 , @barannikov88 > wrote: > >> clangBasic and clangDriver already have a dependency on Target

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. Hi -has anybody any more concern on this change? I'd like to submit it as soon as possible to unlock @mgorny . Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056825 , @barannikov88 wrote: > clangBasic and clangDriver already have a dependency on TargetParser (see > LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not > enough? > Will it build if

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. clangBasic and clangDriver already have a dependency on TargetParser (see LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not enough? Will it build if you just remove the additional dependency? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056671 , @fpetrogalli wrote: > @barannikov88 - I am stuck with an incomplete explanation: Ah, I see. The key point is that standalone build that depends on //installed// LLVM. RISCVTargetParser is a custom tar

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @barannikov88 - Imam stuck with an incomplete explanation: The issue raised by @mgorny is about stand-alone builds. In this build configuration, clang is built separately from LLVM, which is first build

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056612 , @barannikov88 wrote: > In D141581#4056503 , @fpetrogalli > wrote: > >> This is because the sources of clangBasic and clangDriver might be compiled >> before LLV

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056503 , @fpetrogalli wrote: > This is because the sources of clangBasic and clangDriver might be compiled > before LLVMTargetParser is ready. ... > Therefore, if we say that clangDriver and clangBasic depend

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056492 , @tschuett wrote: > I though Clang Basic is a leaf library and must not depend on anything. I wasn't aware of this requirement. As of https://reviews.llvm.org/D137517 it depends on some auto-generated ta

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056464 , @lebedev.ri wrote: > Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is > sufficient to link to `LLVMTargetParser`? This is because the sources of clangBasic and clangDriver might

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tschuett added a comment. I though Clang Basic is a leaf library and must not depend on anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 ___ cfe-commit

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

lebedev.ri added a comment. Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is sufficient to link to `LLVMTargetParser`? Does `RISCVTargetParserTableGen` itself not link to `LLVMTargetParser`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - gentle ping, it would be great if I could unlock @mgorny with this patch for the issue they are seeing at https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf Francesco Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: mgorny. fpetrogalli added a comment. FWIW, the change in this patch solves the issue with standalone build of `clang` reported in https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf. (FYI, @mgorny ) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: craig.topper. fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - is this a better solution to the issue raised in https://reviews.llvm.org/D137517? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/ne

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli created this revision. fpetrogalli added a reviewer: jrtc27. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, arphaman, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits, pcwang-the