This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa44477b1f4b5: [CompilerRT] Remove ubsan static runtime on
Apple (authored by usama54321).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
thetruestblue accepted this revision.
thetruestblue added a comment.
This seems reasonable to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141550/new/
https://reviews.llvm.org/D141550
___
cfe-commit
delcypher accepted this revision.
delcypher added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141550/new/
https://reviews.llvm.org/D141550
_
delcypher added inline comments.
Comment at: compiler-rt/lib/ubsan/CMakeLists.txt:118
+if (NOT APPLE)
+ add_compiler_rt_runtime(clang_rt.ubsan
+STATIC
usama54321 wrote:
> delcypher wrote:
> > I think you may have accidentally added tabs here when
usama54321 marked an inline comment as done.
usama54321 added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:219
+def err_drv_unsupported_static_ubsan_darwin : Error<
+ "Static UBSan runtime is not supported on darwin">;
def err_drv_duplicate_co
usama54321 marked 3 inline comments as done.
usama54321 added inline comments.
Comment at: compiler-rt/lib/ubsan/CMakeLists.txt:118
+if (NOT APPLE)
+ add_compiler_rt_runtime(clang_rt.ubsan
+STATIC
delcypher wrote:
> I think you may have accidenta
usama54321 updated this revision to Diff 488408.
usama54321 added a comment.
Addressing comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141550/new/
https://reviews.llvm.org/D141550
Files:
clang/include/clang/Basic/DiagnosticDriverKinds.td
delcypher added a comment.
Overall approach LGTM. I just have some very minor nits.
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:219
+def err_drv_unsupported_static_ubsan_darwin : Error<
+ "Static UBSan runtime is not supported on darwin">;
def err_drv_dupli
usama54321 created this revision.
Herald added a subscriber: Enna1.
Herald added a project: All.
usama54321 requested review of this revision.
Herald added subscribers: Sanitizers, cfe-commits, MaskRay.
Herald added projects: clang, Sanitizers.
This patch removes the static ubsan runtime on Apple
