[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG92417f2d4b17: [clang][Interp] Record initialization via conditional operator (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm fine with this approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 ___

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 510180. tbaeder added a comment. Screw it, just use a `llvm::function_ref`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCode

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + erichkeane wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > The template de

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + tbaeder wrote: > aaron.ballman wrote: > > The template definition isn't availa

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + aaron.ballman wrote: > The template definition isn't available within the header

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + The template definition isn't available within the header file, so this is

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 504079. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index: clang/test/AST/I

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:200 + using ExprVisitorFunc = std::function; + bool visitConditional(const AbstractConditionalOperator *E, +ExprVisitorFunc VisitFunc); tbaeder wrote: >

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:200 + using ExprVisitorFunc = std::function; + bool visitConditional(const AbstractConditionalOperator *E, +ExprVisitorFunc VisitFunc); tbaeder wrote: > er

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder updated this revision to Diff 489720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141497/new/ https://reviews.llvm.org/D141497 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/records.cpp Index: clang/test/AST/I

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:920 + + Condition->dump(); + if (!this->visit(Condition)) erichkeane wrote: > This meant to be here? Nope! :( Comment at: clang/lib/AST/Interp/ByteCodeExprGen

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:920 + + Condition->dump(); + if (!this->visit(Condition)) This meant to be here? Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:921 + Condition->dum

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Factor this out into a `visitConditional()` that ca